On Sun, Jan 27, 2019 at 01:22:50PM -0800, David Miller wrote: > From: Miquel Raynal <miquel.ray...@bootlin.com> > Date: Fri, 25 Jan 2019 10:55:05 +0100 > > > After a first attempt of bringing S2RAM support to the DSA switch, it > > has been reported that a part of the configuration was lost during the > > cycle. This second version adds a first patch that saves the rules in > > a per-chip list when they are applied, so that in the second patch we > > bring S2RAM support by also re-applying these rules. > ... > > It seems like the discussion on patch #1 has hit a brick wall. > > The last suggestion was to use: > > + switch (mode) { > + case PHY_INTERFACE_MODE_2500BASEX: > + phydev->speed = SPEED_2500; > + break; > + case PHY_INTERFACE_MODE_10GKR: > + phydev->speed = SPEED_10000; > + break; > + > > in dsa_port_fixed_link_register_of(), but that doesn't work > because swphy will fail without speed=1000 in the dts. > > Well, whatever is decided, the commit message need to be updated > to explain why this course of action for the most immediate fix > was ultimately taken.
Hi David Err. I think you are replying to the wrong patch? This comment fits to https://www.spinics.net/lists/netdev/msg546662.html Although i don't like it, i think for the moment we are going to have to accept the proposed fix. Andrew