Re: [PATCH net] net: mvpp2: fix condition for setting up link interrupt

[Andrew Lunn]

On Thu, Jan 24, 2019 at 02:18:03PM +0100, Thomas Bogendoerfer wrote:
> Set up link interrupt if connection is handled by phylink otherwise
> link state change detection for in-band-status doesn't work.

Hi Thomas

Please ensure the maintainers of the driver are at least on Cc:

Thanks
        Andrew

> 
> Fixes: 4bb043262878 ("net: mvpp2: phylink support")
> Signed-off-by: Thomas Bogendoerfer <tbogendoer...@suse.de>
> ---
>  drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c 
> b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> index 16066c2d5b3a..0fbfe1945a69 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> @@ -3405,7 +3405,7 @@ static int mvpp2_open(struct net_device *dev)
>               valid = true;
>       }
>  
> -     if (priv->hw_version == MVPP22 && port->link_irq && !port->phylink) {
> +     if (priv->hw_version == MVPP22 && port->link_irq && port->phylink) {
>               err = request_irq(port->link_irq, mvpp2_link_status_isr, 0,
>                                 dev->name, port);
>               if (err) {
> -- 
> 2.16.4
>