On Wed, 2019-01-23 at 01:48 -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/net/ethernet/intel/igb/e1000_82575.c:636:6: warning: this > statement may fall through [-Wimplicit-fallthrough=] > drivers/net/ethernet/intel/igb/igb_main.c:6710:6: warning: this > statement may fall through [-Wimplicit-fallthrough=] > drivers/net/ethernet/intel/i40e/i40e_xsk.c:237:3: warning: this > statement may fall through [-Wimplicit-fallthrough=] > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enabling > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> > --- > drivers/net/ethernet/intel/i40e/i40e_xsk.c | 3 ++- > drivers/net/ethernet/intel/igb/e1000_82575.c | 2 +- > drivers/net/ethernet/intel/igb/igb_main.c | 2 +- > 3 files changed, 4 insertions(+), 3 deletions(-)
NAK on the igb changes. There is already a "fall through" code comment which is fine, adding a hyphen does not make the comment any more readable. The i40e changes are acceptable, if you want to re-submit with only those changes.
signature.asc
Description: This is a digitally signed message part
