Jiong Wang writes:

<snip>
> +/* BPF_RAND_SEXT_R7 contains 5 instructions, it initializes R7 into a random
> + * negative u32, and sign-extend it into 64-bit.
> + */
> +#define BPF_RAND_SEXT_R7                                             \
> +     BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 0, 0,                       \
> +                  BPF_FUNC_get_prandom_u32),                         \
> +     BPF_MOV64_REG(BPF_REG_7, BPF_REG_0),                            \
> +     BPF_ALU64_IMM(BPF_OR, BPF_REG_7, 0x80000000)                    \
                                                    ^~~~ ',' missing
> +     BPF_ALU64_IMM(BPF_LSH, BPF_REG_7, 32),                          \
> +     BPF_ALU64_IMM(BPF_ARSH, BPF_REG_7, 32),
                                              ^~~~ ',' should be removed

Apology, just found there is a minor fix on testcase that I forget to
commit before generating patch set. One ',' is missing and one ',' should
be removed as described above.

I will correct this in v3 together with other reviews if any.

Regards,
Jiong

Reply via email to