On Tue, 22 Jan 2019 15:38:20 -0700, David Ahern wrote:
> > @@ -5120,6 +5120,9 @@ static int inet6_dump_addr(struct sk_buff *skb,
> > struct netlink_callback *cb,
> > if (idev) {
> > err = in6_dump_addrs(idev, skb, cb, s_ip_idx,
> > &fillargs);
> > + if (err < 0)
> > + goto put_tgt_net;
> > + err = 0;
>
> Rather than have 2 goto's to the same target why not just:
>
> if (err > 0)
> err = 0;
My default is to keep success path less indented and to minimize
dependencies between code blocks. v2 coming in 3.. 2.. 1..
> > }
> > goto put_tgt_net;
> > }
> >
