Re: [PATCH net-next 06/13] net: namespace: perform strict checks also for doit handlers

[Jakub Kicinski]

On Fri, 18 Jan 2019 09:17:46 +0100, Nicolas Dichtel wrote:
> > +static int rtnl_net_valid_getid_req(struct sk_buff *skb,
> > +                               const struct nlmsghdr *nlh,
> > +                               struct nlattr **tb,
> > +                               struct netlink_ext_ack *extack)
> > +{
> > +   int i, err;
> > +
> > +   if (nlh->nlmsg_len < nlmsg_msg_size(sizeof(struct rtgenmsg))) {  
> This is not possible, the check is already done in rtnetlink_rcv_msg().

Good point, thanks!