Re: [PATCH net-next 12/14] net: dsa: Wire up multicast IGMP snooping attribute notification

[Vivien Didelot]

On Wed, 16 Jan 2019 12:01:00 -0800, Florian Fainelli <f.faine...@gmail.com> 
wrote:

> +     int     (*port_multicast_toggle)(struct dsa_switch *ds, int port,
> +                                      bool mc_disabled);
 
Waw this looks counter-intuitive and error-prone... Would you prefer to make it
symmetrical to ops->port_vlan_filtering() by implementing ops->port_multicast()
and passing !obj->u.mc_disabled to it?


Thanks,

        Vivien