On Thu, 10 Jan 2019 at 20:56, Daniel Borkmann <dan...@iogearbox.net> wrote:
>
> On 01/08/2019 11:20 PM, Song Liu wrote:
> > As Naresh reported, test_stacktrace_build_id() causes panic on i386 and
> > arm32 systems. This is caused by page_address() returns NULL in certain
> > cases.
> >
> > This patch fixes this error by using kmap_atomic/kunmap_atomic instead
> > of page_address.
> >
> > Fixes: 615755a77b24 (" bpf: extend stackmap to save binary_build_id+offset
> > instead of address")
> > Reported-by: Naresh Kamboju <naresh.kamb...@linaro.org>
> > Signed-off-by: Song Liu <songliubrav...@fb.com>
Tested-by: Naresh Kamboju <naresh.kamb...@linaro.org>
>
> Looks correct to me, and in this case as per API the assumption is allowed
> that k[un]map_atomic() won't fail. I've applied it to bpf, if Naresh still
> replies with a Tested-by in time, I'll add it as well to the commit.
This patch fixes the problem on Linux kernel 5.0.0-rc2.
Thank you.
Best regards
Naresh Kamboju
