> The actual error that we had from devm_gpiod_get_optional() was > -EPROBE_DEFER, due to the GPIO being provided by a driver that is > probed later than the Ethernet controller driver. > > To fix this, we simply add the missing device_del() invocation in the > error path.
Hi Thomas Reviewed-by: Andrew Lunn <and...@lunn.ch> However, i wounder if it makes sense to add a label before the existing device_del() at the end of the function, and convert this, and the case above into a goto? That might scale better, avoiding the same issue in the future? Thanks Andrew