From: Kazunori MIYAZAWA <[EMAIL PROTECTED]> Date: Thu, 07 Dec 2006 20:23:48 +0900
> David Miller wrote: > > From: David Miller <[EMAIL PROTECTED]> > > Date: Wed, 06 Dec 2006 23:37:49 -0800 (PST) > > > >> From: Kazunori MIYAZAWA <[EMAIL PROTECTED]> > >> Date: Wed, 6 Dec 2006 20:35:37 +0900 > >> > >>> BTW, I have a question about descrementing the reference count of > >>> rt->peer. The reference cound in normal "dst" structure is > >>> decremented by calling inet_putpeer from ipv4_dst_destroy. But > >>> xfrm4_dst_destroy does not call inet_putpeer. Where do we decrement > >>> the count? Should xfrm4_dst_destroy do that? > >> Indeed, it is a real leak. And yes, I believe that xfrm4_dst_destroy() > >> should release it. I will make this fix, thank you. > > > > For reference, this is the fix I checked in. > > > > Thanks again for spotting this problem. > > Thank you for making the patch. > Will it be merged to 2.6.19.x? Yes, I submitted it to -stable last night and Chris W. just queued it up for the -stable branches (even 2.6.18.x etc.) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html