On Mon, Jan 14, 2019 at 1:23 AM Daniel Borkmann <dan...@iogearbox.net> wrote: > Can't we do something like the below instead? Otherwise we'll needlessly > refetch > protocol every time there is a mismatch in above tp->protocol check as well.
Does this save anything given the fact we simply return if err>=0? The protocol must be fetched, either before the loop or inside the loop, before this "if err>=0". If we return, it won't be refetched even with my patch. If we don't, it has to be refetched again. So, I don't see any difference here.
