On Sat, Jan 12, 2019 at 6:50 AM Cong Wang <xiyou.wangc...@gmail.com> wrote:
>
> On Fri, Jan 11, 2019 at 6:19 AM <xiangxia.m....@gmail.com> wrote:
> > @@ -622,17 +629,20 @@ static void mlx5e_rep_neigh_update(struct work_struct
> > *work)
> > memcpy(ha, n->ha, ETH_ALEN);
> > nud_state = n->nud_state;
> > dead = n->dead;
> > + netdev = n->dev;
> > read_unlock_bh(&n->lock);
> >
> > neigh_connected = (nud_state & NUD_VALID) && !dead;
> > + source_mac_changed = (e->h_source == netdev) &&
> > !ether_addr_equal(e->h_source, netdev->dev_addr);
>
> I don't know why you want to compare ->h_source, which points to
> a mac address, with a net_device pointer here.
my fault, but it works, because it also update the source mac. I
simply the implement in v2.