On 1/7/19 10:49 AM, Pavel Machek wrote:
> On Thu 2018-12-06 13:28:56, Vokáč Michal wrote:
>> On 6.12.2018 14:05, Pavel Machek wrote:
>>>
>>> Fix typo and fix compatible value that is not actually permitted by the
>>> description in the example.
>>
>> Ahoj Pavle, I think the subject should be more like:
>>
>> "dt-bindings: net: dsa: ..."
>
> Ahoj!
>
> Well, retrying with different subject only makes sense if someone is
> interested. Rob, Andrew -- can you take the patch?
>
> Do you want me to edit the subject or can you just edit the subject
> while applying?
The next steps would likely be for you to resubmit this patch with a
re-subjected patch and I am fairly sure David can pick it up right away
since this is not a functional change.
>
> Thanks,
> Pavel
>
>> BR, Michal
>>
>>>
>>> Signed-off-by: Pavel Machek <pa...@ucw.cz>
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt
>>> b/Documentation/devicetree/bindings/net/dsa/marvell.txt
>>> index feb007af13cb..abf1be036ac5 100644
>>> --- a/Documentation/devicetree/bindings/net/dsa/marvell.txt
>>> +++ b/Documentation/devicetree/bindings/net/dsa/marvell.txt
>>> @@ -41,7 +41,7 @@ Optional properties:
>>> - mdio : Container of PHY and devices on the switches
>>> MDIO
>>> bus.
>>> - mdio? : Container of PHYs and devices on the external MDIO
>>> - bus. The node must contains a compatible string of
>>> + bus. The node must contain a compatible string of
>>> "marvell,mv88e6xxx-mdio-external"
>>>
>>> Example:
>>> @@ -80,7 +80,7 @@ Example:
>>> #interrupt-cells = <2>;
>>>
>>> switch0: switch@0 {
>>> - compatible = "marvell,mv88e6390";
>>> + compatible = "marvell,mv88e6190";
>>> reg = <0>;
>>> reset-gpios = <&gpio5 1 GPIO_ACTIVE_LOW>;
>>>
>>>
>>>
>
--
Florian
