Daniele Palmas <dnl...@gmail.com> writes: > This patch adds MTU default value to qmap network interface in > order to avoid "RTNETLINK answers: No buffer space available" > error when setting an ipv6 address. > > Signed-off-by: Daniele Palmas <dnl...@gmail.com> > --- > drivers/net/usb/qmi_wwan.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c > index 774e1ff..735ad83 100644 > --- a/drivers/net/usb/qmi_wwan.c > +++ b/drivers/net/usb/qmi_wwan.c > @@ -123,6 +123,7 @@ static void qmimux_setup(struct net_device *dev) > dev->addr_len = 0; > dev->flags = IFF_POINTOPOINT | IFF_NOARP | IFF_MULTICAST; > dev->netdev_ops = &qmimux_netdev_ops; > + dev->mtu = 1500; > dev->needs_free_netdev = true; > }
Setting some value makes sense, but hard coding 1500 feels wrong. Should this relate to the real device mtu somehow? Do we need a ndo_change_mtu to enforce this relationship? Should qmimux_rx_fixup() respect the qmap device mtu? I'm fine with this patch as a first step and immediate fix, so Acked-by: Bjørn Mork <bj...@mork.no>
