create_and_get_cgroup returns 0 on error, fix the users that assume negative value in case of an error.
Signed-off-by: Stanislav Fomichev <s...@google.com> --- tools/testing/selftests/bpf/get_cgroup_id_user.c | 2 +- tools/testing/selftests/bpf/test_sockmap.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/bpf/get_cgroup_id_user.c b/tools/testing/selftests/bpf/get_cgroup_id_user.c index e8da7b39158d..dfaa9b353ac3 100644 --- a/tools/testing/selftests/bpf/get_cgroup_id_user.c +++ b/tools/testing/selftests/bpf/get_cgroup_id_user.c @@ -64,7 +64,7 @@ int main(int argc, char **argv) return 1; cgroup_fd = create_and_get_cgroup(TEST_CGROUP); - if (CHECK(cgroup_fd < 0, "create_and_get_cgroup", "err %d errno %d\n", + if (CHECK(!cgroup_fd, "create_and_get_cgroup", "err %d errno %d\n", cgroup_fd, errno)) goto cleanup_cgroup_env; diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c index e85a771f607b..2384896e8112 100644 --- a/tools/testing/selftests/bpf/test_sockmap.c +++ b/tools/testing/selftests/bpf/test_sockmap.c @@ -1676,7 +1676,7 @@ static int __test_suite(int cg_fd, char *bpf_file) } cg_fd = create_and_get_cgroup(CG_PATH); - if (cg_fd < 0) { + if (!cg_fd) { fprintf(stderr, "ERROR: (%i) open cg path failed: %s\n", cg_fd, optarg); -- 2.20.1.415.g653613c723-goog