On 1/2/19 3:30 PM, Steve Douthit wrote: >> This is because PHYLIB=m which forces MDIO_BUS=m. If you have IXGBE=y, >> then PHYLIB and MDIO_BUS can't be modules. Working on a patch to >> correct the issue. > > There was a review comment to select MDIO_DEVICE instead of PHYLIB. > PHYLIB seems correct to me now that I'm looking at this again though. I > came up empty looking for any other drivers that select MDIO_DEVICE. > > The objection was that DSA devices wouldn't need the PHYLIB API, so why > force it to be built-in. NET_DSA selects PHYLINK which selects PHYLIB. > I think we're ok going back to select PHYLIB if that was the only > problem.
Apologies if this was a slightly misguided recommendation, I have to admit, I did not consider a case where ixgbe would not be modular while everything else it would now depend on is. There is a similar pattern with any driver that e.g: has a HWMON capability in that you must add something like: depends on !FOO=y && DEPS=m or something like that. -- Florian
