On Wed, 26 Dec 2018, Andrew Lunn wrote: > On Wed, Dec 26, 2018 at 05:41:29AM -0600, Robert P. J. Day wrote: > > > > 1) gianfar_phy.c should clearly refer to gianfar.c > > 2) fix obvious copy and paste error in regular doc > > 3) change regular doc into kerneldoc for phy_modes() > > > > Signed-off-by: Robert P. J. Day <rpj...@crashcourse.ca> > > > > --- > > Hi Robert > > > diff --git a/include/linux/phy.h b/include/linux/phy.h > > index 3ea87f774a76..1ca94a51a93e 100644 > > --- a/include/linux/phy.h > > +++ b/include/linux/phy.h > > @@ -1,6 +1,6 @@ > > /* > > * Framework and drivers for configuring and reading different PHYs > > - * Based on code in sungem_phy.c and gianfar_phy.c > > + * Based on code in sungem_phy.c and gianfar.c > > Nope, checkout the commit which added this file: > > git checkout 00db8189d984 > > and take a look around. You will find drivers/net/gianfar_phy.c It has > long since gone, but it was the basis for the framework.
... snip ... ack, i used "git log" assuming it had originally been under drivers/phy ... my bad. will fix that and the other issue. rday