On 24/12/2018 18:08, David Miller wrote: > From: Colin King <colin.k...@canonical.com> > Date: Sat, 22 Dec 2018 16:58:41 +0000 > >> @@ -777,10 +777,7 @@ static void cops_rx(struct net_device *dev) >> } >> >> /* Get response length. */ >> - if(lp->board==DAYNA) >> - pkt_len = inb(ioaddr) & 0xFF; >> - else >> - pkt_len = inb(ioaddr) & 0x00FF; >> + pkt_len = inb(ioaddr); > > There are other instances of similar weird identical statements guarded > by the test on the board type being DAYNA. > > For example, in cops_send_packet(): > > if(lp->board == DAYNA) > outb(skb->len >> 8, ioaddr); > else > outb((skb->len >> 8)&0x0FF, ioaddr); > > Could you scan the rest of the driver and deal with all of these > instances in one go?
Will do, probably in a day or so. > > Thank you! >
