On Wed, Dec 19, 2018 at 6:16 PM Michael S. Tsirkin <m...@redhat.com> wrote: > > On Wed, Dec 19, 2018 at 05:32:27PM -0500, Willem de Bruijn wrote: > > From: Willem de Bruijn <will...@google.com> > > > > Virtio-net devices negotiate LRO support with the host. > > Display the initially negotiated state with ethtool -k. > > > > Also allow configuring it with ethtool -K, reusing the existing > > virtnet_set_guest_offloads helper that disables LRO for XDP. > > > > Virtio-net negotiates TSO4 and TSO6 separately, but ethtool does not > > distinguish between the two. In the unlikely legacy case where the > > host only supports one of the two, maintain the current state. > > > > RTNL is held while calling virtnet_set_features, same as on the path > > from virtnet_xdp_set. > > > > Tested: > > Verified that large-receive-offload is "off [fixed]" when not > > negotiated during initial probe and "on" otherwise. > > > > Measured packet size when scp-ing a large file to the guest with > > nstat (IpExtInOctets / IpInDelivers). Verified that packet size > > exceeds MTU only if ethtool -k shows LRO and/or GRO as enabled. > > > > Signed-off-by: Willem de Bruijn <will...@google.com> > > So I see a bug here: > > virtnet_send_command calls: > /* Caller should know better */ > BUG_ON(!virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ)); > > works fine for XDP because that checks VIRTIO_NET_F_CTRL_GUEST_OFFLOADS > in virtnet_xdp_set.
Oh, indeed. Of course I need to check that flag before advertising as configurable. Thanks!
