On 12/19/18 9:27 AM, Roopa Prabhu wrote:
> + for (i = 0; i <= NDA_MAX; ++i) {
> + if (!tb[i])
> + continue;
> +
> + switch (i) {
> + case NDA_DST:
> + if (nla_len(tb[NDA_DST]) < (int)(*tbl)->key_len) {
that should != instead of <; the address should be exactly the number of
bytes for the address family.
...
> + if (ndm_flags & NTF_PROXY) {
> + struct pneigh_entry *pn;
> +
> + pn = pneigh_lookup(tbl, net, dst, dev, 0);
> + if (!pn) {
> + NL_SET_ERR_MSG(extack, "Proxy neighbour entry not
> found");
> + return -ENOENT;
> + }
> + return pneigh_get_reply(net, pn, NETLINK_CB(in_skb).portid,
> + nlh->nlmsg_seq, tbl);
> + }
> +
> + if (!dev) {
> + NL_SET_ERR_MSG(extack, "No Device specified");
"No device ..."
