Roopa Prabhu <[email protected]> writes: > On Mon, Dec 17, 2018 at 3:44 PM Petr Machata <[email protected]> wrote: >> >> Roopa Prabhu <[email protected]> writes: >> >> Fixes: 0241b836732f ("vxlan: fix default fdb entry netlink notify >> >> ordering during netdev create") >> >> Signed-off-by: Petr Machata <[email protected]> >> >> --- >> > >> > Acked-by: Roopa Prabhu <[email protected]> >> > >> > This fix looks fine. But it almost seems like the changelink Fixes tag >> > is more appropriate here unless you are >> > sure that it worked correctly after the changelink. >> >> I don't follow. What do you mean? > > I meant the notify patch in the Fixes tag had no intentions to change > this. Also the vxlan changelink support > did not consider this as a test case. So i was wondering if this > problem existed before the commit in the Fixes tag.
That patch changed vxlan_fdb_update() to vxlan_fdb_create() in two instances: on changelink, and on create. In changelink, always calling create may lead to a split of the default FDB entry. The fix is basically a revert of that part of the patch. > regardless, ack on the fix. thanks.
