Hi Luca, Reviewed-by: Petr Vorel <pvo...@suse.cz> LGTM, but I'd suggest 2 small changes (see bellow).
> +++ b/testsuite/tests/ip/tunnel/add_tunnel.t > TUNNEL_NAME="tunnel_test_ip" I'd put KMODS here: KMODS="ip6_gre ip6_tunnel ip_gre ip_tunnel gre" The reason is maintenance of this script - maybe one day there will be other modules needed to be added, take this list as a configuration (which is usually in shell scripts in the top). BTW Maintenance was reason why I didn't like duplicity in modules you had in v1. > +# unload kernel modules to remove dummy interfaces only if they were not in > use beforehand > +KMODS_REMOVE= As a side effect, this could be lower case (showing it's not a configuration variable, but just normal variable). > +# note that checkbashism reports command -v, but dash supports it and it's > POSIX 2008 compliant > +if command -v lsmod >/dev/null 2>&1 && command -v rmmod >/dev/null 2>&1; then > + KMODS="ip6_gre ip6_tunnel ip_gre ip_tunnel gre" > + for i in $KMODS; do > + lsmod | grep -q "^$i" || KMODS_REMOVE="$KMODS_REMOVE $i"; > + done > +fi > + > ts_log "[Testing add/del tunnels]" > ts_ip "$0" "Add GRE tunnel over IPv4" tunnel add name $TUNNEL_NAME mode gre > local 1.1.1.1 remote 2.2.2.2 > @@ -12,3 +22,6 @@ ts_ip "$0" "Del GRE tunnel over IPv4" tunnel del > $TUNNEL_NAME > ts_ip "$0" "Add GRE tunnel over IPv6" tunnel add name $TUNNEL_NAME mode > ip6gre local dead:beef::1 remote dead:beef::2 > ts_ip "$0" "Del GRE tunnel over IPv6" tunnel del $TUNNEL_NAME > +for mod in $KMODS_REMOVE; do > + sudo rmmod "$mod" > +done Kind regards, Petr
