On 12/13/2018 03:03 AM, Florian Westphal wrote: > Eric Dumazet <eric.duma...@gmail.com> wrote: >> >> >> On 12/13/2018 02:39 AM, Florian Westphal wrote: >>> >>> Thats whats done in the MPTCP out-of-tree implementation, but I don't >>> think its needed. >>> >>> It could just delete the extension before ->queue_xmit() AFAIU. >> >> So, cloning would do an refcount_inc(), and deleting the extension would do >> an refcount_dec_and_test() ? >> >> That is what I called an extra pair of atomic operations. > > If it replaces 1:1 current mptcp skb->private out-of-tree storage, then > yes. > One day I will write a book on the number of atomic operations done on a TCP sendmsg() system call :/
- Re: [PATCH net-next 02/13] sk_buff: add skb extens... Eric Dumazet
- Re: [PATCH net-next 02/13] sk_buff: add skb ex... Florian Westphal
- Re: [PATCH net-next 02/13] sk_buff: add sk... Eric Dumazet
- Re: [PATCH net-next 02/13] sk_buff: ad... Florian Westphal
- Re: [PATCH net-next 02/13] sk_buf... Eric Dumazet
- Re: [PATCH net-next 02/13] sk... Florian Westphal
- Re: [PATCH net-next 02/13] sk... Eric Dumazet
- Re: [PATCH net-next 02/13] sk... Florian Westphal
- Re: [PATCH net-next 02/13] sk... Eric Dumazet
- Re: [PATCH net-next 02/13] sk... Florian Westphal
- Re: [PATCH net-next 02/13] sk... Eric Dumazet
- Re: [PATCH net-next 02/13] sk... Florian Westphal
- Re: [PATCH net-next 02/13] sk... Christoph Paasch
- Re: [PATCH net-next 02/13] sk_buff: add skb extens... Stephen Suryaputra
- Re: [PATCH net-next 02/13] sk_buff: add skb ex... Florian Westphal
- Re: [PATCH net-next 02/13] sk_buff: add skb ex... David Miller
- [PATCH net-next 01/13] netfilter: avoid using skb->n... Florian Westphal
- [PATCH net-next 06/13] net: use skb_sec_path helper in ... Florian Westphal
- [PATCH net-next 10/13] xfrm: use secpath_exist where ap... Florian Westphal
- [PATCH net-next 03/13] net: convert bridge_nf to use sk... Florian Westphal
- [PATCH net-next 07/13] drivers: net: intel: use secpath... Florian Westphal