Nikolay Aleksandrov <niko...@cumulusnetworks.com> writes: > On 12/12/2018 13:52, Petr Machata wrote: >> int (*ndo_bridge_setlink)(struct net_device *dev, >> struct nlmsghdr *nlh, >> - u16 flags); >> + u16 flags, >> + struct netlink_ext_ack * >> + extack); > > IMO it's better to have struct netlink_ext_ack and extack on the same > line even if it goes a little over 80 here, it is normal for netdevice > ops and wouldn't be the first (check below or above). At first I thought > the arg name is missing. :)
Yeah, I didn't really like this either. It would be 86, which is the reason I broke it like this, but it's not the longest declaration in that file. I'll fold it like you propose.
