Re: [PATCH net-next 13/13] net: switch secpath to use skb extension infrastructure

[Steffen Klassert]

On Mon, Dec 10, 2018 at 03:50:06PM +0100, Florian Westphal wrote:
>  }
> @@ -552,11 +517,6 @@ void __init xfrm_input_init(void)
>       if (err)
>               gro_cells.cells = NULL;
>  
> -     secpath_cachep = kmem_cache_create("secpath_cache",
> -                                        sizeof(struct sec_path),
> -                                        0, SLAB_HWCACHE_ALIGN|SLAB_PANIC,
> -                                        NULL);

This is not so nice. Usually we need a secpath per packet for IPsec.
With removing the cache, we have to kmalloc a secpath for each packet.
This might have some performance impact.