On Mon, Dec 10, 2018 at 1:05 PM Or Gerlitz <gerlitz...@gmail.com> wrote: > > On Mon, Dec 10, 2018 at 10:09 PM Saeed Mahameed > <sae...@dev.mellanox.co.il> wrote: > > > > On Mon, Dec 10, 2018 at 8:12 AM Jason Gunthorpe <j...@mellanox.com> wrote: > > > > > > On Sun, Dec 09, 2018 at 07:04:39PM -0800, Saeed Mahameed wrote: > > > > From: Eli Britstein <el...@mellanox.com> > > > > > > > > Change the driver flow destination struct to use bit flags with the vhca > > > > id valid being the 1st one. Done to avoid bool fields in structs, as > > > > warned by static checkers, with no functionality change. > > > > > > This is a thing now? I thought the warning was not to use bool with > > > bitfields for some reason? > > > > > > > Yea, the commit message is kinda silly, > > hey, sometimes you just want to make your boss happy: > > CHECK: Avoid using bool structure members because of possible > alignment issues - see: https://lkml.org/lkml/2017/11/21/384 > #99: FILE: include/linux/mlx5/fs.h:99: > + bool vhca_id_valid; > > missed anything?
Looks good ! but this wasn't really the purpose of the patch so the commit message didn't have to make a big deal of it.
