Mon, Dec 10, 2018 at 10:21:03AM CET, vasundhara-v.vo...@broadcom.com wrote:
>On Wed, Dec 5, 2018 at 5:24 PM Jiri Pirko <j...@resnulli.us> wrote:
>>
>> Wed, Dec 05, 2018 at 06:56:54AM CET, vasundhara-v.vo...@broadcom.com wrote:
[...]
>> >+ mutex_lock(&devlink->lock);
>> >+ for (i = 0; i < params_count; i++) {
>> >+ if (!param || !param->name || !param->supported_cmodes) {
>> >+ err = -EINVAL;
>> >+ goto rollback;
>> >+ }
>> >+ if (param->generic) {
>> >+ err = devlink_port_param_generic_verify(param);
>> >+ if (err)
>> >+ goto rollback;
>> >+ } else {
>> >+ err = devlink_port_param_driver_verify(param);
>>
>> This is duplicated code from devlink_params_register(). Once you use a
>> single enum for all params, you can push this into a common function for
>> both devlink_params_register() and devlink_port_params_register()
>Jiri, you are referring to move only param verification code into a
>common function. right?
Once you will have a single enum, you need only one verify() function.
