Re: Realtek 8139 driver (8139too.c) TX Timeout doesn't allow interrupt handler to disable receive interrupts at high bi-directional traffic

Wed, 29 Nov 2006 14:46:52 -0800 

Stephen Hemminger <[EMAIL PROTECTED]> :
[...]
> @@ -1682,12 +1685,11 @@ static void rtl8139_tx_timeout_task (voi
>       rtl8139_tx_clear (tp);
>       spin_unlock_irq(&tp->lock);
>  
> +     netif_poll_enable();
                          ^ -> dev
> +
>       /* ...and finally, reset everything */
> -     if (netif_running(dev)) {
> -             rtl8139_hw_start (dev);
> -             netif_wake_queue (dev);
> -     }
> -     spin_unlock_bh(&tp->rx_lock);
> +     rtl8139_hw_start (dev);
> +     netif_wake_queue (dev);
>  }

rtl8139_hw_start() may mess with cur_rx, whence a race with rtl8139_rx()
if an in-flight interruption enables it a bit too fast. I'd rather go
with:
[...]

        rtl8139_tx_clear (tp);

        rtl8139_hw_start (dev);
        netif_wake_queue (dev);
   
        netif_poll_enable(dev);
        spin_unlock_irq(&tp->lock);
}

Otherwise the patch is cool.

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to