On Sun, Dec 2, 2018 at 9:11 PM Cong Wang <xiyou.wangc...@gmail.com> wrote:
>
> On Sun, Dec 2, 2018 at 12:56 AM Tariq Toukan <tar...@mellanox.com> wrote:
> >
> > > + } else if (*proto == htons(ETH_P_IPV6)) {
> >
> > No need for an else here, the first if block always returns.
>
>
> Yeah, but not sure if this makes a difference on the generated
> asm code. I will give it a try anyway.
I just tried, there is no difference on the generated assembly code.
The gcc I use is:
$ gcc --version
gcc (GCC) 8.2.1 20181011 (Red Hat 8.2.1-4)
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Are you okay with the current code now? :)
