On Fri, 2006-11-03 at 17:27 -0500, Michael Wu wrote: > On Thursday 02 November 2006 17:38, Johannes Berg wrote: > > + /* hardware device */ > > + struct device *dev; > > + > Can we just pass this in as an argument instead? No one is gonna look at it > ever again after ieee80211_register_hw, so I don't think it's worth putting > in struct ieee80211_hw.
Actually, it is used for all new devices as well. Yeah, we could pull it out of the mdev again, but it feels stupid to go to so many indirections. The code is already barely understandable. I had a hard time cleaning up the places where struct net_device * is passed, but the only thing it's ever used for is deref'ing ->ieee80211_ptr to get local. > > + local->mdev->class_dev.dev = hw->dev; > Why not use SET_NETDEV_DEV? You're right, it should use that. johannes
signature.asc
Description: This is a digitally signed message part
