When the phydev is put to PHY_HALTED (by e.g. phy_stop()) the state machine suspends the phydev to save power.
However, this is wrongly inside a phydev->link check, causing the phydev not to be suspended if there was no link at the time of stopping it. Fix that by setting do_suspend regardless of whether there was a link or not. Signed-off-by: Anssi Hannula <anssi.hann...@bitwise.fi> Fixes: be9dad1f9f26 ("net: phy: suspend phydev when going to HALTED") Cc: Sebastian Hesselbarth <sebastian.hesselba...@gmail.com> --- drivers/net/phy/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 376a0d8a2b61..d46858694db9 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -956,8 +956,8 @@ void phy_state_machine(struct work_struct *work) if (phydev->link) { phydev->link = 0; phy_link_down(phydev, true); - do_suspend = true; } + do_suspend = true; break; } -- 2.17.2