On Wed, Nov 28, 2018 at 4:05 PM Cong Wang <xiyou.wangc...@gmail.com> wrote: > > On Wed, Nov 28, 2018 at 3:57 PM Cong Wang <xiyou.wangc...@gmail.com> wrote: > > But again, I kinda feel the hardware already does the sanity check, > > otherwise we have much more serious trouble in mlx5e_lro_update_hdr() > > which parses into TCP header. > > > > While we are on this page, mlx5e_lro_update_hdr() incorrectly assumes > TCP header is located right after struct iphdr, which is wrong if we could > have IP options on this path. > > It could the hardware which already verified this corner case though.
yes HW will not do LRO in case of ip options, so no problem in mlx5e_lro_update_hdr
