-----Original Message-----
From: David Miller [mailto:[email protected]] 
Sent: 25 November 2018 07:02
To: Kalluru, Sudarsana <[email protected]>
Cc: [email protected]; Elior, Ariel <[email protected]>; Kalderon, 
Michal <[email protected]>
Subject: Re: [PATCH net-next v2 0/4] qed* enhancements series

External Email

From: Sudarsana Reddy Kalluru <[email protected]>
Date: Fri, 23 Nov 2018 23:42:29 -0800

> v2: Use __set_bit()/__clear_bit() where data access doesn't need to be
>     atomic.

Wait.

How does this interact with the clear_bit_unlock() used by the qede PTP code?
You can't really mix atomic and non-atomic accesses to edev->flags .

Hi Dave,
    I missed this point, thanks a lot for your help/info. Will revert it to use 
set/clear_bit() respectively and, send the V3 version of the series.

Thanks,
Sudarsana

Reply via email to