> I notice 2 problems in the driver:
> 
> 1. netif_napi_add is used instead of netif_tx_napi_add.
> 2. In all other drivers that use netif_tx_napi_add most do not call
> napi_complete_done.
> They all call napi_complete directly and return 0.
> 
> freescale/gianfar.c
> rocker/rocker_main.c
> ti/cpsw.c
> 
> virtio_net.c does use napi_complete_done but it also passes 0 as a
> parameter.
> 
Tristram,

Thanks for the tips. I will make a new version which uses
  netif_tx_napi_add, and napi_complete

Regards,
Bryan

Reply via email to