Tue, Nov 20, 2018 at 06:16:40PM CET, da...@davemloft.net wrote: >From: Jiri Pirko <j...@resnulli.us> >Date: Tue, 20 Nov 2018 08:39:12 +0100 > >> If later on the netfilter code will use it, through another >> ndo/notifier/whatever, that is side a nice side-effect in my >> opinion. > >Netfilter HW offloading is the main motivation of these changes. > >You can try to spin it any way you like, but I think this is pretty >clear. > >Would the author of these changes be even be remotely interested in >this "cleanup" in areas of code he has never been involved in if that >were not the case?
No, but of course. I'm just saying that the cleanup is nice and handy even if the code would never be used by netfilter. Therefore I think the info is irrelevant for the review. Anyway, I get your point. > >I think it is very dishonest to portray the situation differently. > >Thank you.