On 11/15/18 3:36 PM, Stephen Hemminger wrote:
> Several functions only used inside utils.c
>
> Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
> ---
> rdma/rdma.h | 11 -----------
> rdma/utils.c | 12 ++++++------
> 2 files changed, 6 insertions(+), 17 deletions(-)
>
this patch breaks builds for me on Debian stretch:
rdma
CC rdma.o
CC utils.o
CC dev.o
CC link.o
dev.c: In function 'dev_set_name':
dev.c:248:6: warning: implicit declaration of function 'rd_no_arg'
[-Wimplicit-function-declaration]
if (rd_no_arg(rd)) {
^~~~~~~~~
dev.c:256:55: warning: implicit declaration of function 'rd_argv'
[-Wimplicit-function-declaration]
mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_ATTR_DEV_NAME, rd_argv(rd));
^~~~~~~
dev.c:256:55: warning: passing argument 3 of 'mnl_attr_put_strz' makes
pointer from integer without a cast [-Wint-conversion]
In file included from rdma.h:19:0,
from dev.c:12:
/usr/include/libmnl/libmnl.h:103:13: note: expected 'const char *' but
argument is of type 'int'
extern void mnl_attr_put_strz(struct nlmsghdr *nlh, uint16_t type,
const char *data);
Reverting the patch fixes it.
