On Sat, 2018-11-17 at 20:13 +0000, Jason Gunthorpe wrote:
> On Fri, Nov 16, 2018 at 01:59:00PM -0800, Saeed Mahameed wrote:
> > Use the new generic EQ API to move all ODP RDMA data structures and
> > logic
> > form mlx5 core driver into mlx5_ib driver.
> >
> > Signed-off-by: Saeed Mahameed <[email protected]>
> > Reviewed-by: Leon Romanovsky <[email protected]>
> > Reviewed-by: Tariq Toukan <[email protected]>
[...]
> >
> > +struct mlx5_ib_pf_eq {
> > + struct mlx5_ib_dev *dev;
> > + struct mlx5_eq *core;
> > + struct work_struct work;
> > + spinlock_t lock; /* Pagefaults spinlock */
> > + struct workqueue_struct *wq;
> > + mempool_t *pool;
> > +};
>
> I know this is being copied, but can we please not do this vertical
> alignment madness in RDMA? It is such a nightmare to maintain this..
>
Ack will fix and submit v2.
> > +/* mempool_refill() was proposed but unfortunately wasn't accepted
> > + * http://lkml.iu.edu/hypermail/linux/kernel/1512.1/05073.html
> > + * Chip workaround.
>
> 'cheap workaround'
>
Will fix
> Jason
