From: Pablo Neira Ayuso <pa...@netfilter.org>
Date: Fri, 16 Nov 2018 02:41:30 +0100
> static int bnxt_tc_parse_flow(struct bnxt *bp,
> struct tc_cls_flower_offload *tc_flow_cmd,
> struct bnxt_tc_flow *flow)
> {
> - struct flow_dissector *dissector = tc_flow_cmd->dissector;
> + struct flow_rule *rule = &tc_flow_cmd->rule;
> + struct flow_dissector *dissector = rule->match.dissector;
This adds a reverse christmas tree violation. Please fix this up.
> @@ -255,10 +224,12 @@ static void cxgb4_process_flow_match(struct net_device
> *dev,
> static int cxgb4_validate_flow_match(struct net_device *dev,
> struct tc_cls_flower_offload *cls)
> {
> + struct flow_rule *rule = &cls->rule;
> + struct flow_dissector *dissector = rule->match.dissector;
> u16 ethtype_mask = 0;
> u16 ethtype_key = 0;
Likewise.
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
> b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index 21c2688d6308..287cb8665bb3 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -7166,11 +7166,13 @@ static int i40e_parse_cls_flower(struct i40e_vsi *vsi,
> struct tc_cls_flower_offload *f,
> struct i40e_cloud_filter *filter)
> {
> + struct flow_rule *rule = &f->rule;
> + struct flow_dissector *dissector = rule->match.dissector;
> u16 n_proto_mask = 0, n_proto_key = 0, addr_type = 0;
> struct i40e_pf *pf = vsi->back;
> u8 field_flags = 0;
Likewise.
And so on and so forth for your entire submission.
