From: Herbert Xu <herb...@gondor.apana.org.au>
Date: Fri, 16 Nov 2018 09:52:42 +0800

> netdev_rx_csum_fault is meant to warn about the situation where
> a packet with a valid checksum (i.e., sum == 0) was given to us
> by the hardware with a partial checksum that was invalid.

Thanks for reminding us how this code is supposed to work :-)

Definitely we need to better document this and it looks like Cong is
going to add a comment in order to do so.

As for dumping out a packet, we need to rate limit that more strongly
than the existing net_ratelimit() there.  But only dumping once per
bootup seems to extreme in the other direction.  If we get like 2
or 3 of these in an hour, dumping all of them would be reasonable
and useful.

Reply via email to