On 11/15/2018 02:45 PM, Edward Cree wrote:
> On 15/11/18 22:01, Eric Dumazet wrote:
>> On 11/15/2018 01:45 PM, Edward Cree wrote:
>>> If napi->poll() is only handling one packet, surely GRO can't do anything
>>> useful either? (AIUI at the end of the poll the GRO lists get flushed.)
>> That is my point.
>>
>> Adding yet another layer that will add no gain but add more waste of cpu
>> cycles.
>>
>> In fact I know many people disabling GRO in some cases because it adds ~5%
>> penalty
>> for traffic that is not aggregated.
> Does there maybe need to be an (ethtool -K) option to disable batch receive,
> then, for this kind of user?
I do not want to hold on your patches, only to remind us that we add a lot of
features and stuff that might help in some cases only.
Another example is the IP early demux for UDP packets, which is clearly
a waste of time when the receiving socket is not a connected socket.
