Re: [RFC PATCH 2/6] phy: armada38x: add common phy support

[Andrew Lunn]

> +static int a38x_comphy_poll(struct a38x_comphy_lane *lane,
> +                         unsigned int offset, u32 mask, u32 value)
> +{
> +     unsigned int timeout = 10;
> +     u32 val;
> +
> +     while (1) {
> +             val = readl_relaxed(lane->base + offset);
> +             if ((val & mask) == value)
> +                     return 0;
> +             if (!timeout--)
> +                     break;
> +             udelay(10);
> +     }

Hi Russell

Maybe use one of the readx_poll_timeout() variants?

      Andrew