Re: [PATCH net 4/4] qed: Fix reading wrong value in loop condition

[David Miller]

From: Denis Bolotin <denis.bolo...@cavium.com>
Date: Sun, 11 Nov 2018 17:05:00 +0200

> diff --git a/drivers/net/ethernet/qlogic/qed/qed_int.c 
> b/drivers/net/ethernet/qlogic/qed/qed_int.c
> index 0f0aba7..aa7504a 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_int.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_int.c
> @@ -992,6 +992,8 @@ static int qed_int_attentions(struct qed_hwfn *p_hwfn)
>        */
>       do {
>               index = p_sb_attn->sb_index;
> +             /* finish reading index before the loop condition */
> +             rmb();

Please use dma_rmb().