On 11/08, Jakub Kicinski wrote:
> On Thu, 8 Nov 2018 16:22:08 -0800, Stanislav Fomichev wrote:
> > + for (map = bpf_map__prev(map, obj);
> > + map != NULL;
> > + map = bpf_map__prev(map, obj)) {
>
> nit pick: if you need to respin all these for loops on error paths could
> have been more concise while loops
Agreed with everything, will address this one and the other comments in v5.
Thank you for another thorough review!
- [PATCH v4 bpf-next 0/7] bpftool: support loading flow d... Stanislav Fomichev
- [PATCH v4 bpf-next 6/7] bpftool: add pinmaps argum... Stanislav Fomichev
- Re: [PATCH v4 bpf-next 6/7] bpftool: add pinma... Jakub Kicinski
- [PATCH v4 bpf-next 7/7] bpftool: support loading f... Stanislav Fomichev
- Re: [PATCH v4 bpf-next 7/7] bpftool: support l... Jakub Kicinski
- [PATCH v4 bpf-next 2/7] libbpf: cleanup after part... Stanislav Fomichev
- Re: [PATCH v4 bpf-next 2/7] libbpf: cleanup af... Jakub Kicinski
- Re: [PATCH v4 bpf-next 2/7] libbpf: cleanu... Stanislav Fomichev
- [PATCH v4 bpf-next 1/7] selftests/bpf: rename flow... Stanislav Fomichev
- [PATCH v4 bpf-next 4/7] libbpf: add internal pin_n... Stanislav Fomichev
- Re: [PATCH v4 bpf-next 4/7] libbpf: add intern... Jakub Kicinski
- [PATCH v4 bpf-next 3/7] libbpf: bpf_program__pin: ... Stanislav Fomichev
- [PATCH v4 bpf-next 5/7] bpftool: add loadall comma... Stanislav Fomichev
- Re: [PATCH v4 bpf-next 5/7] bpftool: add loada... Jakub Kicinski
- Re: [PATCH v4 bpf-next 5/7] bpftool: add loada... Quentin Monnet
- Re: [PATCH v4 bpf-next 5/7] bpftool: add l... Stanislav Fomichev
