On 11/08/2018 11:47 AM, Edward Cree wrote:
> As added in 3e59020abf0f ("net: bql: add __netdev_tx_sent_queue()"), which
> see for performance rationale.
>
> Signed-off-by: Edward Cree <ec...@solarflare.com>
> ---
> drivers/net/ethernet/sfc/tx.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c
> index c3ad564ac4c0..22eb059086f7 100644
> --- a/drivers/net/ethernet/sfc/tx.c
> +++ b/drivers/net/ethernet/sfc/tx.c
> @@ -553,13 +553,10 @@ netdev_tx_t efx_enqueue_skb(struct efx_tx_queue
> *tx_queue, struct sk_buff *skb)
> if (!data_mapped && (efx_tx_map_data(tx_queue, skb, segments)))
> goto err;
>
> - /* Update BQL */
> - netdev_tx_sent_queue(tx_queue->core_txq, skb_len);
> -
> efx_tx_maybe_stop_queue(tx_queue);
>
> /* Pass off to hardware */
> - if (!xmit_more || netif_xmit_stopped(tx_queue->core_txq)) {
> + if (__netdev_tx_sent_queue(tx_queue->core_txq, skb_len, xmit_more)) {
> struct efx_tx_queue *txq2 = efx_tx_queue_partner(tx_queue);
>
> /* There could be packets left on the partner queue if those
>
Reviewed-by: Eric Dumazet <eduma...@google.com>
Thanks !
