On Wed, 7 Nov 2018 15:12:07 -0800, Stanislav Fomichev wrote: > > > I agree, constructing the jmp_table is a bit fragile with all the > > > dependencies on the order of the progs. I'll drop that and will send a > > > v2 that pins all the programs from the obj file instead and offloads > > > jmp_table construction to the user. So the supposed use case would be > > > something like the following: > > > > > > bpftool prog load bpf_flow.o /sys/fs/bpf/flow type flow_dissector > > > > Okay. One more thing - how do we differentiate between mass pin and the > > existing pin first behaviour? Should we perhaps add a loadall command > > or some flag? > In v2 I did by program type: > * flow_dissector -> pin all > * not flow_dissector -> pin first? > > But we can have loadall or something like: > load OBJ [pinfirst|pinall] FILE|DIR [type TYPE] > > If we want to add user control, I'd go with loadall command, > adding more optional flags in between is a mess..
I think user control would be good. Agreed on loadall being better.
