On Wed, 7 Nov 2018 at 13:37, Andrey Ignatov <[email protected]> wrote: > > Lookup functions in sk_lookup have different expectations about byte > order of provided arguments. > > Specifically __inet_lookup, __udp4_lib_lookup and __udp6_lib_lookup > expect dport to be in network byte order and do ntohs(dport) internally. > > At the same time __inet6_lookup expects dport to be in host byte order > and correspondingly name the argument hnum. > > sk_lookup works correctly with __inet_lookup, __udp4_lib_lookup and > __inet6_lookup with regard to dport. But in __udp6_lib_lookup case it > uses host instead of expected network byte order. It makes result > returned by bpf_sk_lookup_udp for IPv6 incorrect. > > The patch fixes byte order of dport passed to __udp6_lib_lookup. > > Originally sk_lookup properly handled UDPv6, but not TCPv6. 5ef0ae84f02a > fixes TCPv6 but breaks UDPv6. > > Fixes: 5ef0ae84f02a ("bpf: Fix IPv6 dport byte-order in bpf_sk_lookup") > Signed-off-by: Andrey Ignatov <[email protected]>
Thanks for the fix, makes sense. Acked-by: Joe Stringer <[email protected]>
