Since you need to re-send once net-next opens ... On 11/2/18 1:10 PM, Mike Manning wrote: > diff --git a/include/net/inet_hashtables.h b/include/net/inet_hashtables.h > index 4ae060b4bac2..5de2d9f24c05 100644 > --- a/include/net/inet_hashtables.h > +++ b/include/net/inet_hashtables.h > @@ -189,6 +189,17 @@ static inline void inet_ehash_locks_free(struct > inet_hashinfo *hashinfo) > hashinfo->ehash_locks = NULL; > } > > +static inline bool inet_sk_bound_dev_eq(struct net *net, int bound_dev_if, > + int dif, int sdif) > +{ > +#if IS_ENABLED(CONFIG_NET_L3_MASTER_DEV) > + return inet_bound_dev_eq(net->ipv4.sysctl_tcp_l3mdev_accept, > + bound_dev_if, dif, sdif);
Column misalignment on the bound_dev_if. Also, since the arg to inet_bound_dev_eq is a bool, that should be !!net->ipv4.sysctl_tcp_l3mdev_accept > +#else > + return inet_bound_dev_eq(1, bound_dev_if, dif, sdif); > +#endif > +} > + > struct inet_bind_bucket * > inet_bind_bucket_create(struct kmem_cache *cachep, struct net *net, > struct inet_bind_hashbucket *head,