On 11/5/18 6:06 PM, David Miller wrote: > From: Alexey Kodanev <alexey.koda...@oracle.com> > Date: Fri, 2 Nov 2018 19:11:04 +0300 > >> For non-zero return from dumpit() we should break the loop >> in rtnl_dump_all() and return the result. Otherwise, e.g., >> we could get the memory leak in inet6_dump_fib() [1]. The >> pointer to the allocated struct fib6_walker there (saved >> in cb->args) can be lost, reset on the next iteration. >> >> Fix it by partially restoring the previous behavior before >> commit c63586dc9b3e ("net: rtnl_dump_all needs to propagate >> error from dumpit function"). The returned error from >> dumpit() is still passed further. > ... >> Fixes: c63586dc9b3e ("net: rtnl_dump_all needs to propagate error from >> dumpit function") >> Signed-off-by: Alexey Kodanev <alexey.koda...@oracle.com> > > Applied. >
Lost track of these in the noise of the past few days. Thanks for the fixes Alexey.