On Sat, 2018-11-03 at 19:36 -0700, David Miller wrote:
> From: Saeed Mahameed <sae...@mellanox.com>
> Date: Fri, 2 Nov 2018 18:54:22 -0700
>
> > +static void mlx5e_fold_sw_stats(struct mlx5e_priv *priv, struct
> > rtnl_link_stats64 *s)
> > +{
> > + int i;
> > +
> > + /* not required ? */
> > + memset(s, 0, sizeof(*s));
>
> Why wouldn't this be required?
>
I just checked it is already done by the stack @dev_get_stats()
> I can see that perhaps you can only zero out the statistics that are
> used in
>
> the ndo_get_stats64() code path, but that's different.
mlx5e_fold_sw_stats can only be called from ndo_get_stats64().
The "s" pointer i am trying to zero out here is the same pointer we
receive from ndo_get_stats64().
