Hello,
On 22-10-2018 13:28, Andrew Lunn wrote:
>> EXPORT_SYMBOL_GPL(gen10g_resume);
>> @@ -327,7 +381,7 @@ struct phy_driver genphy_10g_driver = {
>> .phy_id = 0xffffffff,
>> .phy_id_mask = 0xffffffff,
>> .name = "Generic 10G PHY",
>> - .soft_reset = gen10g_no_soft_reset,
>> + .soft_reset = gen10g_soft_reset,
>> .config_init = gen10g_config_init,
>> .features = 0,
>> .aneg_done = genphy_c45_aneg_done,
> Hi Jose
>
> You need to be careful here. There is a reason this is called
> gen10g_no_soft_reset, rather than having an empty
> gen10g_soft_reset. Some PHYs break when you do a reset. So adding a
> gen10g_soft_reset is fine, but don't change this here, without first
> understanding the history, and talking to Russell King.
Hmm, the reset function only interacts with standard PCS
registers, which should always be available ...
>From my tests I need to do at least 1 reset during power-up so in
ultimate case I can add a feature quirk or similar.
Russell, can you please comment ?
Thanks and Best Regards,
Jose Miguel Abreu
>
> Andrew
